fix: URI components are not encoded correctly (#1640) #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas-Bergmann
force-pushed
the
fix/1640-EncodeURIComponents
branch
from
bc48a68
to
827ab56
Compare
Thomas-Bergmann
changed the title
shauke
previously approved these changes
May 3, 2024
* only constants doesn't need to be encoded The URI component will be done by encodeResourceID. In case ICM is fixed the project can change it to single encoding at one place.
* using encodeResourceID in the tests too allows a single switch at that function.
shauke
force-pushed
the
fix/1640-EncodeURIComponents
branch
from
0ef6c44
to
9fafc13
Compare
shauke
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Issue Number: Closes #1640
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
The PR provides a central function to select two behavior:
see encodeResourceID at src/app/core/utils/url-resource-ids.ts
[] Yes
[X] No
Other Information
To be able to use "single" encoded URI components a new versions of ICM application server and HTTPD configuration are necessary.
ICM-AS fix required - removes duplicate decoding (12.0.0)
ICM-WA fix required - allow encoded slashes in URIs
AB#96081